[US-4.3 / OBT-206] Multi-select platforms with checkboxes - #16
Open
Conversation
Replace the single Web/Mobile/Both dropdown in the app create and edit forms with a PlatformMultiSelect toggle group (Web, Android, iOS) that allows any combination. Require at least one platform before saving, pre-select the current platforms when editing, and send the selection as an array. Remove the transitional legacy<->array bridge introduced in US-4.2.
1 task
These pr-us-*.md files are local PR notes that were bundled into the feature commit by mistake; they should never have been tracked/pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Local decision notes bundled into the feature commit by mistake; never meant to be tracked/pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
US-4.3 / OBT-206 — Let admins select any combination of platforms (Web, Android, iOS) independently when creating or editing an app, replacing the single Web/Mobile/Both dropdown.
Changes
src/components/common/PlatformMultiSelect.tsx— a reusable toggle-button group (Web, Android, iOS) styled with Shema tokens; active options use the telha accent.AppsPage.tsx: form state is nowplatforms: string[]; the create/edit dialog usesPlatformMultiSelect; requires at least one platform (toast on empty); sends the array to the API. Removed the transitional legacy bridge.AppDetailPage.tsx: same treatment for the edit dialog; editing pre-selects the app's current platforms.Type of Change
Testing
npm run typecheck— passnpm run lint— 0 errors (pre-existing ProjectsPage warning only)npm run build— pass